[
https://issues.apache.org/jira/browse/SCB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426581#comment-16426581
]
ASF GitHub Bot commented on SCB-422:
------------------------------------
WillemJiang commented on a change in pull request #633: [SCB-422] Threadpool
metrics
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/633#discussion_r179373685
##########
File path:
metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/TestAnMonitorManager.java
##########
@@ -41,7 +41,7 @@
private static MetricsLoader currentWindowMetricsLoader;
- private static MetricsLoader nextWindowMetricsLoader;
+ // private static MetricsLoader nextWindowMetricsLoader;
Review comment:
Why did you comment out these code?
If we don't need them, we can just remove them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> add executor metrics, not just queue size
> -----------------------------------------
>
> Key: SCB-422
> URL: https://issues.apache.org/jira/browse/SCB-422
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: wujimin
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
