[ 
https://issues.apache.org/jira/browse/SCB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428365#comment-16428365
 ] 

ASF GitHub Bot commented on SCB-422:
------------------------------------

wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/633#discussion_r179767736
 
 

 ##########
 File path: 
service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/http/TestClientPool.java
 ##########
 @@ -17,43 +17,16 @@
 
 package org.apache.servicecomb.serviceregistry.client.http;
 
-import org.apache.servicecomb.serviceregistry.config.ServiceRegistryConfig;
 import org.junit.Test;
 
-import io.vertx.core.http.HttpVersion;
-import mockit.Mock;
-import mockit.MockUp;
-
 public class TestClientPool {
   @Test
   public void testHttpClientPool() {
-    new MockUp<ServiceRegistryConfig>() {
-      @Mock
-      public HttpVersion getHttpVersion() {
-        return HttpVersion.HTTP_2;
-      }
-
-      @Mock
-      public boolean isSsl() {
-        return true;
-      }
-    };
     HttpClientPool.INSTANCE.create();
 
 Review comment:
   oh, yes.
   i only confirmed with author and deleted useless code, did not realize this 
is not a effective test case
   and the next case have the same problem.
   
   i will confirmed with author again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> add executor metrics, not just queue size
> -----------------------------------------
>
>                 Key: SCB-422
>                 URL: https://issues.apache.org/jira/browse/SCB-422
>             Project: Apache ServiceComb
>          Issue Type: Sub-task
>          Components: Java-Chassis
>            Reporter: wujimin
>            Assignee: wujimin
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to