[ 
https://issues.apache.org/jira/browse/SCB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428352#comment-16428352
 ] 

ASF GitHub Bot commented on SCB-422:
------------------------------------

wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/633#discussion_r179764368
 
 

 ##########
 File path: 
metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/TestAnMonitorManager.java
 ##########
 @@ -41,7 +41,7 @@
 
   private static MetricsLoader currentWindowMetricsLoader;
 
-  private static MetricsLoader nextWindowMetricsLoader;
+  //  private static MetricsLoader nextWindowMetricsLoader;
 
 Review comment:
   cause random UT failed.
   this class, and related classes will be deleted in the next PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> add executor metrics, not just queue size
> -----------------------------------------
>
>                 Key: SCB-422
>                 URL: https://issues.apache.org/jira/browse/SCB-422
>             Project: Apache ServiceComb
>          Issue Type: Sub-task
>          Components: Java-Chassis
>            Reporter: wujimin
>            Assignee: wujimin
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to