[
https://issues.apache.org/jira/browse/SCB-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541663#comment-16541663
]
ASF GitHub Bot commented on SCB-706:
------------------------------------
coveralls edited a comment on issue #803: [SCB-706]change filters to discovery
filters and support invocation based filters
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/803#issuecomment-404380842
[](https://coveralls.io/builds/17953764)
Coverage decreased (-0.04%) to 87.085% when pulling
**2847bf48a0879c2026e75660f91edc6bf6a2e61d on liubao68:test-11** into
**b00f4c748122460ba1484815ed9c98eadf9eba31 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> refactor loadbalance filters logic to support invocation based filter
> ---------------------------------------------------------------------
>
> Key: SCB-706
> URL: https://issues.apache.org/jira/browse/SCB-706
> Project: Apache ServiceComb
> Issue Type: Improvement
> Reporter: liubao
> Assignee: liubao
> Priority: Major
>
> Why we do this?
> # When implement invocation based filter, e.g. darklaunch deployment, we
> need to filter servers based on invocation parameters. But now, we create a
> Loadbalaner instance for each service, and Robin filter interface can not
> pass Invocation to it. Before refactor, we doing this by ThreadLocal and
> cache Invocation, and use in filter implementation. This is error prone and
> users can't handle this complixity
> # We have other improvements, e.g. SCB-700, we can do server status check,
> and add a filter a choose from active servers. We need to consider filter
> orders and other feature, current implementation not satisfy this.
> # We want to make loadbalance code handy by remove some compatible fixes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
