[
https://issues.apache.org/jira/browse/SCB-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532336#comment-16532336
]
ASF GitHub Bot commented on SCB-706:
------------------------------------
liubao68 commented on a change in pull request #786: [SCB-706]refactor
loadbalance filters logic to support invocation based filter
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/786#discussion_r200020756
##########
File path:
demo/demo-springmvc/springmvc-client/src/main/resources/microservice.yaml
##########
@@ -54,10 +54,6 @@ servicecomb:
retryEnabled: true
retryOnSame: 1
retryOnNext: 1
- serverListFilters: zoneaware
Review comment:
It's not a compatible change, you can see many compatible check code to help
user change their code. As above comments given by wujimin, maybe I need move
entirely to DiscoveryFilter to improve performance. I'll think about this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> refactor loadbalance filters logic to support invocation based filter
> ---------------------------------------------------------------------
>
> Key: SCB-706
> URL: https://issues.apache.org/jira/browse/SCB-706
> Project: Apache ServiceComb
> Issue Type: Improvement
> Reporter: liubao
> Assignee: liubao
> Priority: Major
>
> Why we do this?
> # When implement invocation based filter, e.g. darklaunch deployment, we
> need to filter servers based on invocation parameters. But now, we create a
> Loadbalaner instance for each service, and Robin filter interface can not
> pass Invocation to it. Before refactor, we doing this by ThreadLocal and
> cache Invocation, and use in filter implementation. This is error prone and
> users can't handle this complixity
> # We have other improvements, e.g. SCB-700, we can do server status check,
> and add a filter a choose from active servers. We need to consider filter
> orders and other feature, current implementation not satisfy this.
> # We want to make loadbalance code handy by remove some compatible fixes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
