[
https://issues.apache.org/jira/browse/SCB-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541766#comment-16541766
]
ASF GitHub Bot commented on SCB-706:
------------------------------------
wujimin commented on a change in pull request #803: [SCB-706]change filters to
discovery filters and support invocation based filters
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/803#discussion_r202064032
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/discovery/AbstractDiscoveryFilter.java
##########
@@ -30,6 +30,9 @@ public DiscoveryTreeNode discovery(DiscoveryContext context,
DiscoveryTreeNode p
}
String childName = findChildName(context, parent);
+ if (childName == null) {
+ return null;
Review comment:
when will this happened?
after return null, DiscoveryTree will throw exception:
```
// impossible, throw exception to help fix bug
throw new ServiceCombException(filter.getClass().getName() + " discovery
return null.");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> refactor loadbalance filters logic to support invocation based filter
> ---------------------------------------------------------------------
>
> Key: SCB-706
> URL: https://issues.apache.org/jira/browse/SCB-706
> Project: Apache ServiceComb
> Issue Type: Improvement
> Reporter: liubao
> Assignee: liubao
> Priority: Major
>
> Why we do this?
> # When implement invocation based filter, e.g. darklaunch deployment, we
> need to filter servers based on invocation parameters. But now, we create a
> Loadbalaner instance for each service, and Robin filter interface can not
> pass Invocation to it. Before refactor, we doing this by ThreadLocal and
> cache Invocation, and use in filter implementation. This is error prone and
> users can't handle this complixity
> # We have other improvements, e.g. SCB-700, we can do server status check,
> and add a filter a choose from active servers. We need to consider filter
> orders and other feature, current implementation not satisfy this.
> # We want to make loadbalance code handy by remove some compatible fixes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
