[
https://issues.apache.org/jira/browse/SCB-962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660215#comment-16660215
]
ASF GitHub Bot commented on SCB-962:
------------------------------------
KomachiSion commented on a change in pull request #322: [SCB-962] Support
ForwardPolicy to configure the maximum of retries
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/322#discussion_r227263608
##########
File path: docs/api/api.md
##########
@@ -46,10 +48,12 @@ JSON parameters:
- transaction - user-defined transaction that executed by the Saga.
- method - user-defined, HTTP method.
- path - user-defined, HTTP path.
+ - retries - int, optional, default -1. The max retry times for
transaction. If this parameter is less than or equal to 0, transaction will
retry infinitely.
- params - support `form`,`json`,`body`,`query`.
- compensation - user-defined compensation that executed by the Saga.
- method - user-defined, HTTP method.
- path - user-defined, HTTP path.
+ - retries - int, optional, default 3. The max retry times for compensation.
Review comment:
When compensation set retries less than or equal to 0, it will be set
default value.
This is the logic that was there, I have not changed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The forwardPolicy of Saga can configure the maximum of retries
> --------------------------------------------------------------
>
> Key: SCB-962
> URL: https://issues.apache.org/jira/browse/SCB-962
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
> Affects Versions: saga-0.2.0
> Reporter: Sion Yang
> Assignee: Sion Yang
> Priority: Major
> Fix For: saga-0.3.0
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Currently, forwardPolicy would keep trying transaction part when transaction
> failed, which may cause saga retry transaction infinitely.
> So it's necessary to configure the maximum of transaction retries.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
