[
https://issues.apache.org/jira/browse/SCB-962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660246#comment-16660246
]
ASF GitHub Bot commented on SCB-962:
------------------------------------
KomachiSion commented on a change in pull request #322: [SCB-962] Support
ForwardPolicy to configure the maximum of retries
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/322#discussion_r227275169
##########
File path:
saga-core/src/main/java/org/apache/servicecomb/saga/core/Fallback.java
##########
@@ -34,6 +34,11 @@ public SagaResponse send(String address) {
public SagaResponse send(String address, SagaResponse response) {
return send(address);
}
+
+ @Override
+ public int retries() {
+ return 0;
Review comment:
No, Fallback does not retry currently.
Because I abstracted the retires method from Compensation to Operation,
Fallback needs to implement this method temporarily.
Considering the default number of retries if Fallback needs to retry in the
future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> The forwardPolicy of Saga can configure the maximum of retries
> --------------------------------------------------------------
>
> Key: SCB-962
> URL: https://issues.apache.org/jira/browse/SCB-962
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
> Affects Versions: saga-0.2.0
> Reporter: Sion Yang
> Assignee: Sion Yang
> Priority: Major
> Fix For: saga-0.3.0
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Currently, forwardPolicy would keep trying transaction part when transaction
> failed, which may cause saga retry transaction infinitely.
> So it's necessary to configure the maximum of transaction retries.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
