[
https://issues.apache.org/jira/browse/SCB-962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660271#comment-16660271
]
ASF GitHub Bot commented on SCB-962:
------------------------------------
zhfeng commented on a change in pull request #322: [SCB-962] Support
ForwardPolicy to configure the maximum of retries
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/322#discussion_r227282280
##########
File path:
saga-core/src/main/java/org/apache/servicecomb/saga/core/ForwardRecovery.java
##########
@@ -49,6 +49,15 @@ public SagaResponse apply(SagaTask task, SagaRequest
request, SagaResponse paren
ignored);
throw new TransactionFailedException(ignored);
}
+ throw new TransactionAbortedException(
+ String.format(
+ "Too many failures in transaction %s of service %s, abort the
transaction!",
+ request.transaction(),
+ request.serviceName()));
+ }
+
+ private boolean isRetryable(int i, Transaction transaction) {
+ return transaction.retries() == Transaction.INFINITE_RETRY || i <=
transaction.retries();
Review comment:
Thanks @KomachiSion , as i starts from 0
> for(int i = 0; isRetryable(i, request.transaction()); i++)
it looks like the condition should be i < transcaction.retries() ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The forwardPolicy of Saga can configure the maximum of retries
> --------------------------------------------------------------
>
> Key: SCB-962
> URL: https://issues.apache.org/jira/browse/SCB-962
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
> Affects Versions: saga-0.2.0
> Reporter: Sion Yang
> Assignee: Sion Yang
> Priority: Major
> Fix For: saga-0.3.0
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Currently, forwardPolicy would keep trying transaction part when transaction
> failed, which may cause saga retry transaction infinitely.
> So it's necessary to configure the maximum of transaction retries.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
