[
https://issues.apache.org/jira/browse/SCB-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704202#comment-16704202
]
ASF GitHub Bot commented on SCB-1047:
-------------------------------------
liubao68 commented on a change in pull request #1013:
[SCB-1047]microservice.yaml service_description.version support form…
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1013#discussion_r237735298
##########
File path: core/src/test/java/org/apache/servicecomb/core/TestConfig.java
##########
@@ -53,7 +53,7 @@ public void testConstants() {
Assert.assertEquals("rest", Const.RESTFUL);
Assert.assertEquals("", Const.ANY_TRANSPORT);
Assert.assertEquals("latest", Const.VERSION_RULE_LATEST);
- Assert.assertEquals("0.0.0+", Const.DEFAULT_VERSION_RULE);
+ Assert.assertEquals("0.0.0.0+", Const.DEFAULT_VERSION_RULE);
Review comment:
I think we do not need to change the VERSION_RULE_ALL constant. 3 bit used
more widely and 4 bit is for specail users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> microservice.yaml service_description.version support format xxx.xx.xxx.xxx
> ----------------------------------------------------------------------------
>
> Key: SCB-1047
> URL: https://issues.apache.org/jira/browse/SCB-1047
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: 何一乐
> Assignee: 何一乐
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
