[
https://issues.apache.org/jira/browse/SCB-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706747#comment-16706747
]
ASF GitHub Bot commented on SCB-1047:
-------------------------------------
wujimin commented on a change in pull request #1013:
[SCB-1047]microservice.yaml service_description.version support form…
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1013#discussion_r238156830
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/version/VersionRuleUtils.java
##########
@@ -54,7 +54,17 @@ public static VersionRule create(String strVersionRule) {
return versionRule;
}
}
+ throw new IllegalStateException("config service_description.version is
invalid ");
+ }
- throw new IllegalStateException("never run to here");
+ public static void checkVersionFormat(String strVersionRule) {
+ strVersionRule = strVersionRule.trim();
Review comment:
named check version, but checking versionRule?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> microservice.yaml service_description.version support format xxx.xx.xxx.xxx
> ----------------------------------------------------------------------------
>
> Key: SCB-1047
> URL: https://issues.apache.org/jira/browse/SCB-1047
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: 何一乐
> Assignee: 何一乐
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
