[
https://issues.apache.org/jira/browse/SCB-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708306#comment-16708306
]
ASF GitHub Bot commented on SCB-1047:
-------------------------------------
wujimin commented on a change in pull request #1013:
[SCB-1047]microservice.yaml service_description.version support form…
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1013#discussion_r238551795
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/version/Version.java
##########
@@ -74,34 +78,52 @@ private short parseNumber(String name, String allVersion,
String version) {
return value;
}
- public Version(short major, short minor, short patch) {
+ public Version(short major, short minor, short patch, short build) {
this.major = major;
this.minor = minor;
this.patch = patch;
+ this.build = build;
this.version = combineStringVersion();
this.numberVersion = combineVersion();
}
private String combineStringVersion() {
- return major + "." + minor + "." + patch;
+ StringBuilder stringBuilder = new StringBuilder();
+ stringBuilder.append(major)
+ .append(".")
+ .append(minor)
+ .append(".")
+ .append(patch)
+ .append(".")
+ .append(build);
+ return stringBuilder.toString();
}
+ // 1.0.0 equals 1.0.0.0
private long combineVersion() {
- return (long) major << 32 | (long) minor << 16 | (long) patch;
+ return (long) major << 48 | (long) minor << 32 | (long) patch << 16 |
(long) build;
}
+ @VisibleForTesting
Review comment:
why VisibleForTesting?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> microservice.yaml service_description.version support format xxx.xx.xxx.xxx
> ----------------------------------------------------------------------------
>
> Key: SCB-1047
> URL: https://issues.apache.org/jira/browse/SCB-1047
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: 何一乐
> Assignee: 何一乐
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
