[
https://issues.apache.org/jira/browse/SHINDIG-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106730#comment-13106730
]
[email protected] commented on SHINDIG-1622:
--------------------------------------------------------
bq. On 2011-09-16 18:47:49, Stanton Sievers wrote:
bq. >
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/LinkSpec.java,
line 74
bq. > <https://reviews.apache.org/r/1928/diff/2/?file=41488#file41488line74>
bq. >
bq. > Is there a particular reason getMethod() isn't being added to
GadgetsHandlerApi.LinkSpec?
bq.
bq. Henry Saputra wrote:
bq. No reason other than forget cause its too many duplicate classes for
different purpose =(
bq.
bq. I will add it in the code.
bq.
bq. Henry Saputra wrote:
bq. Actually the GadgetHandler code no longer has reference to the
GadgetsHandlerApi.LinkSpec. Do you know where its used now?
Never mind its refactored to GadgetsHandlerService =)
- Henry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1928/#review1936
-----------------------------------------------------------
On 2011-09-16 18:16:57, Henry Saputra wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1928/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-16 18:16:57)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The <Link> representation LinkSpec class missing "method" optional
property as defined in the OpenSocial specs:
http://opensocial-resources.googlecode.com/svn/spec/2.0/Core-Gadget.xml#LifeCycleEvents
bq.
bq.
bq. This addresses bug SHINDIG-1622.
bq. https://issues.apache.org/jira/browse/SHINDIG-1622
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/LinkSpec.java
1171202
bq.
trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/LinkSpecTest.java
1171202
bq.
bq. Diff: https://reviews.apache.org/r/1928/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated the unit test for LinkSpec and pass.
bq.
bq.
bq. Thanks,
bq.
bq. Henry
bq.
bq.
> Add support for optional "method" parameter in the LinkSpec implementation
> --------------------------------------------------------------------------
>
> Key: SHINDIG-1622
> URL: https://issues.apache.org/jira/browse/SHINDIG-1622
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.0-RC2, 2.0.2
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Labels: gadget
> Attachments: SHINDIG-1622.patch
>
>
> The <Link> representation LinkSpec class missing "method" optional property
> as defined in the OpenSocial specs:
> http://opensocial-resources.googlecode.com/svn/spec/2.0/Core-Gadget.xml#LifeCycleEvents
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
