[
https://issues.apache.org/jira/browse/SHINDIG-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106875#comment-13106875
]
[email protected] commented on SHINDIG-1622:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1928/
-----------------------------------------------------------
(Updated 2011-09-16 22:32:42.088063)
Review request for shindig.
Changes
-------
Check for valid method names based review from Stanton.
Summary
-------
The <Link> representation LinkSpec class missing "method" optional property as
defined in the OpenSocial specs:
http://opensocial-resources.googlecode.com/svn/spec/2.0/Core-Gadget.xml#LifeCycleEvents
This addresses bug SHINDIG-1622.
https://issues.apache.org/jira/browse/SHINDIG-1622
Diffs (updated)
-----
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
1171202
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/LinkSpec.java
1171202
trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/LinkSpecTest.java
1171202
Diff: https://reviews.apache.org/r/1928/diff
Testing
-------
Updated the unit test for LinkSpec and pass.
Thanks,
Henry
> Add support for optional "method" parameter in the LinkSpec implementation
> --------------------------------------------------------------------------
>
> Key: SHINDIG-1622
> URL: https://issues.apache.org/jira/browse/SHINDIG-1622
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.0-RC2, 2.0.2
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Labels: gadget
> Attachments: SHINDIG-1622.patch
>
>
> The <Link> representation LinkSpec class missing "method" optional property
> as defined in the OpenSocial specs:
> http://opensocial-resources.googlecode.com/svn/spec/2.0/Core-Gadget.xml#LifeCycleEvents
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
