[
https://issues.apache.org/jira/browse/SHINDIG-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106845#comment-13106845
]
[email protected] commented on SHINDIG-1622:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1928/#review1947
-----------------------------------------------------------
Ship it!
One more thing to consider then this LGTM.
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/LinkSpec.java
<https://reviews.apache.org/r/1928/#comment4428>
The spec says the value can be either "POST" or "GET". This implementation
allows it to be anything. It could be left up to the implementor to sanitize
the inputs or it could be done here. I don't feel strongly either way, just
wanted to bring it up.
- Stanton
On 2011-09-16 19:53:07, Henry Saputra wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1928/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-16 19:53:07)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The <Link> representation LinkSpec class missing "method" optional
property as defined in the OpenSocial specs:
http://opensocial-resources.googlecode.com/svn/spec/2.0/Core-Gadget.xml#LifeCycleEvents
bq.
bq.
bq. This addresses bug SHINDIG-1622.
bq. https://issues.apache.org/jira/browse/SHINDIG-1622
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
1171202
bq.
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/LinkSpec.java
1171202
bq.
trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/LinkSpecTest.java
1171202
bq.
bq. Diff: https://reviews.apache.org/r/1928/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated the unit test for LinkSpec and pass.
bq.
bq.
bq. Thanks,
bq.
bq. Henry
bq.
bq.
> Add support for optional "method" parameter in the LinkSpec implementation
> --------------------------------------------------------------------------
>
> Key: SHINDIG-1622
> URL: https://issues.apache.org/jira/browse/SHINDIG-1622
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.0-RC2, 2.0.2
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Labels: gadget
> Attachments: SHINDIG-1622.patch
>
>
> The <Link> representation LinkSpec class missing "method" optional property
> as defined in the OpenSocial specs:
> http://opensocial-resources.googlecode.com/svn/spec/2.0/Core-Gadget.xml#LifeCycleEvents
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
