[
https://issues.apache.org/jira/browse/SHINDIG-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201318#comment-13201318
]
[email protected] commented on SHINDIG-1698:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3764/#review4831
-----------------------------------------------------------
There seems to be trailing whitespace and some tabs in this patch. Can you
clean those up please?
/trunk/java/common/src/main/java/org/apache/shindig/protocol/RequestItem.java
<https://reviews.apache.org/r/3764/#comment10615>
In BaseRequestItem there is already a "public Map<String, Object>
getParameters()". Can that API simply be added to the RequestItem interface
instead of introducing a new method altogether? You'd then just get the keySet
from that instead of using getParameterNames().
- Stanton
On 2012-02-06 13:25:25, li xu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3764/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-06 13:25:25)
bq.
bq.
bq. Review request for shindig and Eric Woods.
bq.
bq.
bq. Summary
bq. -------
bq.
bq.
bq. We have a use case that need to support optional parameters on Social REST
API.
bq.
bq. Per open social spec discussion, provider specific parameter can be
supported. Please see the link below for details.
bq.
https://groups.google.com/forum/#!topic/opensocial-and-gadgets-spec/rOBmu4QGtwg
bq.
bq. This patch implemented optional parameter as a field in CollectionOptions.
bq.
bq.
bq. This addresses bug SHINDIG-1698.
bq. https://issues.apache.org/jira/browse/SHINDIG-1698
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/trunk/java/common/src/main/java/org/apache/shindig/protocol/RequestItem.java
1238916
bq.
/trunk/java/common/src/main/java/org/apache/shindig/protocol/BaseRequestItem.java
1238916
bq.
/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptions.java
1238916
bq.
bq. Diff: https://reviews.apache.org/r/3764/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Passed junit tests. tested with a backend that supports optional
parameters.
bq.
bq.
bq. Thanks,
bq.
bq. li
bq.
bq.
> Need to support query parameter for Social REST API
> ---------------------------------------------------
>
> Key: SHINDIG-1698
> URL: https://issues.apache.org/jira/browse/SHINDIG-1698
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Reporter: li xu
> Fix For: 3.0.0
>
> Attachments: parameter_patch.txt
>
>
> We have a use case that need to support optional parameters on Social REST
> API.
> Per open social spec discussion, provider specific parameter can be
> supported. Please see the link below for details.
> https://groups.google.com/forum/#!topic/opensocial-and-gadgets-spec/rOBmu4QGtwg
> This patch implemented optional parameter as a field in CollectionOptions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
