[
https://issues.apache.org/jira/browse/SHINDIG-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201637#comment-13201637
]
[email protected] commented on SHINDIG-1698:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3764/
-----------------------------------------------------------
(Updated 2012-02-06 21:47:43.400978)
Review request for shindig and Eric Woods.
Changes
-------
cleaned up trailing spaces.
Thanks for pointing out getParameters. I checked it again and it's not in the
RequestItem interface. I think we don't need to get a copy the whole Parameter
Collection, it's sufficient to return the keys and request individual value
based on need.
Summary
-------
We have a use case that need to support optional parameters on Social REST API.
Per open social spec discussion, provider specific parameter can be supported.
Please see the link below for details.
https://groups.google.com/forum/#!topic/opensocial-and-gadgets-spec/rOBmu4QGtwg
This patch implemented optional parameter as a field in CollectionOptions.
This addresses bug SHINDIG-1698.
https://issues.apache.org/jira/browse/SHINDIG-1698
Diffs (updated)
-----
/trunk/java/common/src/main/java/org/apache/shindig/protocol/BaseRequestItem.java
1238916
/trunk/java/common/src/main/java/org/apache/shindig/protocol/RequestItem.java
1238916
/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptions.java
1238916
Diff: https://reviews.apache.org/r/3764/diff
Testing
-------
Passed junit tests. tested with a backend that supports optional parameters.
Thanks,
li
> Need to support query parameter for Social REST API
> ---------------------------------------------------
>
> Key: SHINDIG-1698
> URL: https://issues.apache.org/jira/browse/SHINDIG-1698
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Reporter: li xu
> Fix For: 3.0.0
>
> Attachments: parameter_patch.txt
>
>
> We have a use case that need to support optional parameters on Social REST
> API.
> Per open social spec discussion, provider specific parameter can be
> supported. Please see the link below for details.
> https://groups.google.com/forum/#!topic/opensocial-and-gadgets-spec/rOBmu4QGtwg
> This patch implemented optional parameter as a field in CollectionOptions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
