[
https://issues.apache.org/jira/browse/SHINDIG-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249846#comment-13249846
]
[email protected] commented on SHINDIG-1698:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4680/#review6790
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptions.java
<https://reviews.apache.org/r/4680/#comment15064>
Small style nit, space between Map parameters
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptions.java
<https://reviews.apache.org/r/4680/#comment15065>
instead of using new HashSet use Maps.newHashSet
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptions.java
<https://reviews.apache.org/r/4680/#comment15068>
I don't understand why this can't be private static final..you are using
package visible fields on RequestItem, you don't need an instance of it
RequestItem. Is it because its package visible?
I tried it locally and it worked fine.
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptions.java
<https://reviews.apache.org/r/4680/#comment15066>
style nit, put a space between the map parameters
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptions.java
<https://reviews.apache.org/r/4680/#comment15067>
Style nit put a space between the map parameters
- Ryan
On 2012-04-09 06:54:36, Yao Zhang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4680/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-09 06:54:36)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Eric Woods, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is the patch for https://reviews.apache.org/r/3764 as xuli is not
working on it.
bq. @Ryan, I have merged line 58 and 59 of
/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptions.java
and break line 60 into multiple lines. As predefinedParameters is using
RequestItem, it can not be changed to private static final.
bq.
bq.
bq. This addresses bug SHINDIG-1698.
bq. https://issues.apache.org/jira/browse/SHINDIG-1698
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/protocol/BaseRequestItem.java
1311123
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/protocol/RequestItem.java
1311123
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptions.java
1311123
bq.
bq. Diff: https://reviews.apache.org/r/4680/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. done
bq.
bq.
bq. Thanks,
bq.
bq. Yao
bq.
bq.
> Need to support query parameter for Social REST API
> ---------------------------------------------------
>
> Key: SHINDIG-1698
> URL: https://issues.apache.org/jira/browse/SHINDIG-1698
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0-beta1
> Reporter: li xu
> Fix For: 2.5.0
>
> Attachments: parameter_patch.txt
>
>
> We have a use case that need to support optional parameters on Social REST
> API.
> Per open social spec discussion, provider specific parameter can be
> supported. Please see the link below for details.
> https://groups.google.com/forum/#!topic/opensocial-and-gadgets-spec/rOBmu4QGtwg
> This patch implemented optional parameter as a field in CollectionOptions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
