[
https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272280#comment-13272280
]
[email protected] commented on SHINDIG-1772:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5085/#review7765
-----------------------------------------------------------
I am wondering if we want to try to not break backwards compatibility with this
change. If there are gadgets out there that are passing VIEWER_SIGNED or
OWNER_SIGNED as params they will stop working. While I think the chance of
this is small, the code to support it is trivial. Comments in the code
indicating why we look for both parameters would help too.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js
<https://reviews.apache.org/r/5085/#comment17072>
I prefer we use the new constant here
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js
<https://reviews.apache.org/r/5085/#comment17073>
I prefer we use the new constant here
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js
<https://reviews.apache.org/r/5085/#comment17074>
I prefer we use the new constant here
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js
<https://reviews.apache.org/r/5085/#comment17075>
I prefer we use the new constant here
- Ryan
On 2012-05-10 03:44:35, Erik Bi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5085/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-10 03:44:35)
bq.
bq.
bq. Review request for Ryan Baxter, Dan Dumont and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and
'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and
in fact looks for the wrong parameters. In io.js Shindig looks for
'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER'
should be made constants.
bq.
bq.
bq. This addresses bug shindig-1772.
bq. https://issues.apache.org/jira/browse/shindig-1772
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js
1327432
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js
1327432
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js
1327432
bq.
bq. Diff: https://reviews.apache.org/r/5085/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Update iotest.js
bq.
bq.
bq. Thanks,
bq.
bq. Erik
bq.
bq.
> gadgets.io.RequestParameters.SIGN_OWNER and
> gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and
> 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these
> and in fact looks for the wrong parameters. In io.js Shindig looks for
> 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and
> 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
