[
https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273290#comment-13273290
]
[email protected] commented on SHINDIG-1772:
--------------------------------------------------------
bq. On 2012-05-10 12:38:56, Ryan Baxter wrote:
bq. > I am wondering if we want to try to not break backwards compatibility
with this change. If there are gadgets out there that are passing
VIEWER_SIGNED or OWNER_SIGNED as params they will stop working. While I think
the chance of this is small, the code to support it is trivial. Comments in
the code indicating why we look for both parameters would help too.
bq.
bq. Stanton Sievers wrote:
bq. +1
bq.
bq. Erik Bi wrote:
bq. Yes, it's easy to support both, but I thought that the chance somebody
was using it should be very small, and if somebody did, he must have been
looking through the code and found the parameter name, because it doesn't exist
in the spec, and that is wrong...
bq. Do you think maybe it's better I ask around the shindig group see if
someone used the old value before? if there is, we will add the support for old
value but comment it deprecated, if not, just drop them.
I cant argue with anything you are saying, but I figured since it would take
very little effort to add backward compatibility it wouldn't be a big deal.
However the chance of people running into this is probably small so I don't see
that strongly about it.
Please add the Shindig group as a reviewer.
bq. On 2012-05-10 12:38:56, Ryan Baxter wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js,
line 449
bq. > <https://reviews.apache.org/r/5085/diff/2/?file=108271#file108271line449>
bq. >
bq. > I prefer we use the new constant here
bq.
bq. Erik Bi wrote:
bq. the reason I still see the parameter name instead the constant is
because I want to to keep constant with other code in the makeRequest function,
as you can see, in this function, it checks many parameters, but all use the
string value directly instead of the constant. your opinion?
Just because the rest of the code does it doesn't mean its the best thing to
do. At least by using the constants you are "testing" them and making sure
their values are what you expect.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5085/#review7765
-----------------------------------------------------------
On 2012-05-10 03:44:35, Erik Bi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5085/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-10 03:44:35)
bq.
bq.
bq. Review request for Ryan Baxter, Dan Dumont and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and
'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and
in fact looks for the wrong parameters. In io.js Shindig looks for
'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER'
should be made constants.
bq.
bq.
bq. This addresses bug shindig-1772.
bq. https://issues.apache.org/jira/browse/shindig-1772
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js
1327432
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js
1327432
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js
1327432
bq.
bq. Diff: https://reviews.apache.org/r/5085/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Update iotest.js
bq.
bq.
bq. Thanks,
bq.
bq. Erik
bq.
bq.
> gadgets.io.RequestParameters.SIGN_OWNER and
> gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and
> 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these
> and in fact looks for the wrong parameters. In io.js Shindig looks for
> 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and
> 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
