[
https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272518#comment-13272518
]
Ryan Baxter commented on SHINDIG-1772:
--------------------------------------
Rich I think I am a little confused on what you are saying here, when you say
client are you talking about the gadget or the container?
With the current patch, if my gadget used the old shindig defined constants
then my gadget's functionality could break. For example setting the old
parameters to false will cause Shindig not to add any extra URL parameters when
making the request for a request token. If the provider you are doing the
dance with is very strict and there are extra parameters on the request it may
reject the request all together. When I go to use my gadget in a 2.5 container
all of a sudden it will stop working. It won't take much to support both so we
can avoid situations like this.
> gadgets.io.RequestParameters.SIGN_OWNER and
> gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and
> 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these
> and in fact looks for the wrong parameters. In io.js Shindig looks for
> 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and
> 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira