desruisseaux commented on code in PR #40:
URL: https://github.com/apache/sis/pull/40#discussion_r2792457457
##########
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java:
##########
@@ -148,7 +213,7 @@ public synchronized void close() throws IOException {
final S3Client c = client;
client = null;
if (c != null) try {
- provider.dispose(accessKey);
+ provider.dispose(new ClientFileSystemKey(accessKey, host, port,
isHttps));
Review Comment:
Potential `NullPointerException` here as the `ClientFileSystemKey`
constructor expects a primitive `boolean`. As a fix, I propose to replace the
`Boolean` argument of this constructor by `boolean`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
