desruisseaux commented on code in PR #40:
URL: https://github.com/apache/sis/pull/40#discussion_r2792532430
##########
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java:
##########
@@ -107,6 +146,31 @@ public class FileService extends FileSystemProvider {
*/
public static final String AWS_SECRET_ACCESS_KEY = "aws.secretAccessKey";
+ /**
+ * The property for the host (mandatory if you do not want to use AWS S3).
+ * Values shall be instances of {@link String}.
+ *
+ * @see #newFileSystem(URI, Map)
+ */
+ public static final String S3_HOST_URL = "s3.hostUrl";
+
+ /**
+ * The property for the port (mandatory if you do not want to use AWS S3).
Review Comment:
Avoid "you" (taking inspiration from the rules in writing of OGC documents).
The sentence could be reworded for example as "mandatory if not using AWS S3)".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
