desruisseaux commented on code in PR #40:
URL: https://github.com/apache/sis/pull/40#discussion_r2792648584
##########
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/KeyPath.java:
##########
@@ -199,7 +202,13 @@ final class KeyPath implements Path {
* If {@code false}, will be determined automatically.
* @throws InvalidPathException if the path uses a protocol other than
{@value #SCHEME}.
*/
- KeyPath(final ClientFileSystem fs, final String first, final String[]
more, boolean isAbsolute) {
+ KeyPath(final ClientFileSystem fs, String first, final String[] more,
boolean isAbsolute) {
+ Pattern pattern = Pattern.compile("^S3://[^@]+@([^/]+)(/.*)?$");
Review Comment:
If this constructor is invoked often, maybe the pattern should be compiled
once for all as a private static final field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
