desruisseaux commented on code in PR #40:
URL: https://github.com/apache/sis/pull/40#discussion_r2792562087
##########
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java:
##########
@@ -237,47 +331,96 @@ final class Creator implements Function<String,
ClientFileSystem> {
* Removes the given file system from the cache.
* This method is invoked after the file system has been closed.
*/
- final void dispose(String identifier) {
+ final void dispose(ClientFileSystemKey identifier) {
if (identifier == null) {
- identifier = DEFAULT_ACCESS_KEY;
+ identifier = new ClientFileSystemKey(DEFAULT_ACCESS_KEY,
DEFAULT_HOST_KEY, DEFAULT_PORT_KEY, DEFAULT_IS_HTTPS);
Review Comment:
Consider creating a `private static final ClientFileSystemKey DEFAULT_KEY`
with all those default values instead. It may remove the need to define all the
other `DEFAULT_` fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
