desruisseaux commented on code in PR #40:
URL: https://github.com/apache/sis/pull/40#discussion_r2792587427
##########
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java:
##########
@@ -216,17 +283,44 @@ public FileSystem newFileSystem(final URI uri, final
Map<String,?> properties) t
} else {
region = Containers.property(properties, AWS_REGION, Region.class);
}
- final class Creator implements Function<String, ClientFileSystem> {
+ final class Creator implements Function<ClientFileSystemKey,
ClientFileSystem> {
/** Identifies if a new file system is created. */ boolean created;
/** Invoked if the map does not already contains the file system.
*/
- @Override public ClientFileSystem apply(final String key) {
+ @Override public ClientFileSystem apply(final ClientFileSystemKey
key) {
created = true;
- return new ClientFileSystem(FileService.this, region, key,
secret, separator);
+ return new ClientFileSystem(FileService.this, region,
key.getHost(), key.getPort(), key.isHttps(), key.getAccessKey(), secret,
separator);
}
}
+
+ Boolean isHttps;
+ if ((isHttps = Containers.property(properties, S3_IS_HTTPS,
Boolean.class)) == null) {
+ isHttps = DEFAULT_IS_HTTPS;
+ }
+
Review Comment:
For consistency with formatting in other SIS classes, when there is a block
of comment covering many lines, we often use:
```
/*
* ...
*/
```
instead of `//`. It also provides a visual separation that avoid the needs
to insert blank lines inside the method body. The other classes ins SIS rarely
use blank lines inside method body, and reserves those blank lines for
separating fields and methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
