NazerkeBS commented on a change in pull request #23:
URL: https://github.com/apache/solr/pull/23#discussion_r603906237
##########
File path: solr/core/src/java/org/apache/solr/cloud/ZkCLI.java
##########
@@ -231,9 +233,8 @@ public static void main(String[] args) throws
InterruptedException,
stdout.println("A chroot was specified in zkHost but the znode
doesn't exist. ");
System.exit(1);
}
- ZkConfigManager configManager = new ZkConfigManager(zkClient);
final Pattern excludePattern = Pattern.compile(excludeExpr);
- configManager.uploadConfigDir(Paths.get(confDir), confName,
excludePattern);
+ ZkMaintenanceUtils.uploadToZK(zkClient, Paths.get(confDir),
ZkMaintenanceUtils.CONFIGS_ZKNODE + "/" + confName, excludePattern);
Review comment:
In this case, I have to overload uploadConfig method to add
excludePattern param in ConfigSetService
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
