dsmiley commented on a change in pull request #23:
URL: https://github.com/apache/solr/pull/23#discussion_r604371316
##########
File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java
##########
@@ -57,7 +57,7 @@ public static ConfigSetService
createConfigSetService(CoreContainer coreContaine
final ConfigSetService configSetService = instantiate(coreContainer);
try {
bootstrapDefaultConfigSet(configSetService);
- } catch (IOException e) {
+ } catch (UnsupportedOperationException | IOException e) {
Review comment:
Hmm. Let's catch just UnsupportedOperation. If anything else is
thrown; let it propagate to the caller (thus declare that this method throws
IOException). I can see in the current code (not this PR), this is what would
happen -- it's not swallowed. (not propagating an exception is called
swallowing it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
