dsmiley commented on a change in pull request #23:
URL: https://github.com/apache/solr/pull/23#discussion_r604372030
##########
File path:
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java
##########
@@ -62,7 +60,13 @@ public String configSetName(CoreDescriptor cd) {
@Override
public boolean checkConfigExists(String configName) throws IOException {
- return true;
+ List<String> configs = listConfigs();
+ for (String config : configs) {
Review comment:
Why call endsWith?
listConfigs should return a simple list of config names. If it doesn't (if
it returns path info with slashes) then it's broken and should be fixed.
Making the change here as you did works around a root cause; always fix root
causes instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
