[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357347#comment-17357347
]
Erick Erickson commented on SOLR-14920:
---------------------------------------
So I'll raise the question, then stay out of the debate and abide by whatever
active folks decide... How long should we wait for the reference impl to be
integrated before tackling this seriously? My original reluctance to do
anything with this was based on trying to reconcile a massively reformatted
code base with the massive changes in the reference impl. How long can/should
we wait before going forward? Who plans on actually doing that work? Or is it
just time to carry this forward and let the reference impl integration deal
with it?
And if we do go forward, Dawid shepherded a process that put all the formatting
changes in a conveniently-ignored merge, who will take that responsibility? Not
me, since I'm avoiding responsibility in retirement ;)
> Format code automatically and enforce it in Solr
> ------------------------------------------------
>
> Key: SOLR-14920
> URL: https://issues.apache.org/jira/browse/SOLR-14920
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Priority: Major
> Labels: codestyle, formatting
> Time Spent: 40m
> Remaining Estimate: 0h
>
> See the discussion at: LUCENE-9564.
> This is a placeholder for the present, I'm reluctant to do this to the Solr
> code base until after:
> * we have some Solr-specific consensus
> * we have some clue what this means for the reference impl.
> Reconciling the reference impl will be difficult enough without a zillion
> format changes to add to the confusion.
> So my proposal is
> 1> do this.
> 2> Postpone this until after the reference impl is merged.
> 3> do this in one single commit for reasons like being able to conveniently
> have this separated out from git blame.
> Assigning to myself so it doesn't get lost, but anyone who wants to take it
> over please feel free.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
