[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363722#comment-17363722
]
Christine Poerschke commented on SOLR-14920:
--------------------------------------------
Just a note to say that the above two commits complete the
{{contrib/jaegertracer-configurator}} reformatting work for {{solr/main}} and I
opted to not backport to {{lucene-solr/branch_8x}} due to merge conflict.
It seems the LUCENE-9564 reformatting was also only for {{lucene-solr/master}}
now {{lucene/main}} branches, though I can see that perhaps in some specific
cases partial or full backporting could be useful. So by not backporting for
{{contrib/jaegertracer-configurator}} here i do _not_ intend to set a precedent
or argue against other backports in future, these things can be considered and
decided on a case by case basis in my opinion.
> Format code automatically and enforce it in Solr
> ------------------------------------------------
>
> Key: SOLR-14920
> URL: https://issues.apache.org/jira/browse/SOLR-14920
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Priority: Major
> Labels: codestyle, formatting
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> See the discussion at: LUCENE-9564.
> This is a placeholder for the present, I'm reluctant to do this to the Solr
> code base until after:
> * we have some Solr-specific consensus
> * we have some clue what this means for the reference impl.
> Reconciling the reference impl will be difficult enough without a zillion
> format changes to add to the confusion.
> So my proposal is
> 1> do this.
> 2> Postpone this until after the reference impl is merged.
> 3> do this in one single commit for reasons like being able to conveniently
> have this separated out from git blame.
> Assigning to myself so it doesn't get lost, but anyone who wants to take it
> over please feel free.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
