janhoy commented on a change in pull request #372:
URL: https://github.com/apache/solr/pull/372#discussion_r737857540
##########
File path:
solr/core/src/java/org/apache/solr/handler/admin/SegmentsInfoRequestHandler.java
##########
@@ -434,4 +435,9 @@ public String getDescription() {
public Category getCategory() {
return Category.ADMIN;
}
+
+ @Override
+ public Name getPermissionName(AuthorizationContext request) {
+ return Name.CONFIG_READ_PERM;
Review comment:
I think I agree that this is metrics. But if you have search (READ)
access and CONFIG_READ permission so you can use the Admin UI, should you then
be denied viewing the segment page if you lack METRICS permission? I guess
people will learn this and assign a role with necessary permissions. I'll
switch this to `METRICS_READ_PERM`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
