janhoy commented on a change in pull request #372:
URL: https://github.com/apache/solr/pull/372#discussion_r737870861
##########
File path:
solr/core/src/java/org/apache/solr/handler/admin/ZookeeperInfoHandler.java
##########
@@ -103,6 +104,18 @@ public Category getCategory() {
return Category.ADMIN;
}
+ @Override
+ public Name getPermissionName(AuthorizationContext request) {
+ var params = request.getParams();
+ var path = params.get("path", "");
+ var detail = params.get("detail", "false");
+ if ("/security.json".equalsIgnoreCase(path) &&
"true".equalsIgnoreCase(detail)) {
+ return Name.SECURITY_READ_PERM;
+ } else {
+ return Name.CONFIG_READ_PERM;
Review comment:
Hmm, this handler reads all of ZK, which mostly contains configuration.
But there is also a `ZK_READ_PERM` available, so if we have to pick only one,
perhaps that should be used instead. here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
