janhoy commented on a change in pull request #372:
URL: https://github.com/apache/solr/pull/372#discussion_r737863235
##########
File path:
solr/core/src/java/org/apache/solr/handler/admin/PluginInfoHandler.java
##########
@@ -82,4 +83,9 @@ public String getDescription() {
public Category getCategory() {
return Category.ADMIN;
}
+
+ @Override
+ public Name getPermissionName(AuthorizationContext request) {
+ return Name.METRICS_READ_PERM;
Review comment:
The `/solr/<coll>/admin/plugins` endpoint lists all other implicit
endpoints (plugins) available, and by adding `stats=true` you get all kids of
stats for the MBeans. So this smells metrics to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]