janhoy commented on a change in pull request #372:
URL: https://github.com/apache/solr/pull/372#discussion_r742982104
##########
File path:
solr/core/src/java/org/apache/solr/handler/admin/LukeRequestHandler.java
##########
@@ -105,6 +106,11 @@
static final int HIST_ARRAY_SIZE = 33;
+ @Override
+ public Name getPermissionName(AuthorizationContext request) {
+ return Name.CONFIG_READ_PERM;
Review comment:
It also exposes schema which is configuration. But I guess data is more
sensitive, so better choose READ for this. Then users can setup custom
permissions that require diferent roles to read data from different
collections, and this will obey.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]