janhoy commented on a change in pull request #372:
URL: https://github.com/apache/solr/pull/372#discussion_r742990786
##########
File path: solr/core/src/java/org/apache/solr/handler/DumpRequestHandler.java
##########
@@ -127,4 +135,19 @@ public void init(NamedList<?> args) {
if (nl!=null) subpaths = nl.getAll("subpath");
}
}
+
+ @Override
+ public Name getPermissionName(AuthorizationContext request) {
+ if (solrCore != null && solrCore.getSolrConfig().isEnableRemoteStreams()) {
+ log.warn("Dump request handler requires config-read permission when
remote streams are enabled");
+ return Name.CONFIG_READ_PERM;
Review comment:
This shuold increase security a bit, in case remote streaming is
enabled.. Although, if someone has permission to switch on remote streaming,
they would likely also have the config-edit and config-read permissions...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
