janhoy commented on a change in pull request #403:
URL: https://github.com/apache/solr/pull/403#discussion_r772698361
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -944,6 +946,14 @@ public void load() {
});
clusterSingletons.setReady();
+ if
(NodeRoles.PREFERRED.equals(nodeRoles.getRoleMode(NodeRoles.Role.OVERSEER))) {
+ try {
+ log.info("This node is started as a preferred overseer");
Review comment:
Do we want role-specific if-then-else code in CoreContainer? I think
there were some questions in the SIP discussion regarding where role logic
should reside, and this does not seem very pluggable nor scalable.
What if NodeRole was an interface and each role was an implementation. Then
CoreContainer could call some init method on each configured role when the node
starts up, and that class would then do whatever it wants wrt reading its
config, logging, talking to zk etc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
