murblanc commented on a change in pull request #403:
URL: https://github.com/apache/solr/pull/403#discussion_r772756813
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -944,6 +946,14 @@ public void load() {
});
clusterSingletons.setReady();
+ if
(NodeRoles.PREFERRED.equals(nodeRoles.getRoleMode(NodeRoles.Role.OVERSEER))) {
+ try {
+ log.info("This node is started as a preferred overseer");
Review comment:
Given the goal of a role is to influence behavior (here related to
Overseer, elsewhere to placing or not placing data, in the future other
aspects), I don't see how to make this pluggable. Sure the definition of the
role can be pluggable, but to make the role be able to actually change the
behavior of Solr, existing classes have to be patched.
What you suggest @janhoy is possible (discovering/initializing all roles and
letting them do that work), but the missing bit is then for roles that want to
change some specific behavior aspects of SolrCloud or interact with it in a
different way than tweaking its configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
