janhoy commented on a change in pull request #606:
URL: https://github.com/apache/solr/pull/606#discussion_r801208411
##########
File path: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java
##########
@@ -95,11 +95,11 @@ public final boolean authenticate(HttpServletRequest
request, HttpServletRespons
}
}
- HttpServletRequest wrapWithPrincipal(HttpServletRequest request, Principal
principal) {
+ protected HttpServletRequest wrapWithPrincipal(HttpServletRequest request,
Principal principal) {
Review comment:
Example of base-class method that required same-package for plugins.
With this change the auth plugins can be any package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
