janhoy commented on a change in pull request #606:
URL: https://github.com/apache/solr/pull/606#discussion_r801802481
##########
File path:
solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginTest.java
##########
@@ -64,21 +64,30 @@
// Shared with other tests
static HashMap<String, Object> testJwk;
+ public static Path JWT_TEST_PATH() {
+ return getFile("solr/security").getParentFile().toPath();
+ }
+
static {
- // Generate an RSA key pair, which will be used for signing and
verification of the JWT, wrapped in a JWK
+ // Generate an RSA key pair, which will be used for signing and
verification of the JWT, wrapped
+ // in a JWK
try {
rsaJsonWebKey = RsaJwkGenerator.generateJwk(2048);
rsaJsonWebKey.setKeyId("k1");
testJwk = new HashMap<>();
testJwk.put("kty", rsaJsonWebKey.getKeyType());
- testJwk.put("e",
BigEndianBigInteger.toBase64Url(rsaJsonWebKey.getRsaPublicKey().getPublicExponent()));
+ testJwk.put(
+ "e",
+
BigEndianBigInteger.toBase64Url(rsaJsonWebKey.getRsaPublicKey().getPublicExponent()));
Review comment:
Did a shot in #611
I first applied Spotless on JWT classes while still in solr-core. We can
merge that one commit as a separate PR first.
Then rebased this branch on top, with some quashing etc to make the edit
history more clean.
Hope you like it :)
I did not dare to force-push the same to this same branch. No idea what
would happen to the PR and review comment history if I did. So we can close
this and finalize in #611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
