madrob commented on a change in pull request #606: URL: https://github.com/apache/solr/pull/606#discussion_r801249798
########## File path: solr/licenses/bcutil-LICENSE-MIT.txt ########## @@ -0,0 +1,15 @@ +Copyright (c) 2000-2010 The Legion Of The Bouncy Castle (http://www.bouncycastle.org) Review comment: https://www.bouncycastle.org/license.html has updated dates (up to 2021). Not sure how much this matters. ########## File path: solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginTest.java ########## @@ -64,21 +64,30 @@ // Shared with other tests static HashMap<String, Object> testJwk; + public static Path JWT_TEST_PATH() { + return getFile("solr/security").getParentFile().toPath(); + } + static { - // Generate an RSA key pair, which will be used for signing and verification of the JWT, wrapped in a JWK + // Generate an RSA key pair, which will be used for signing and verification of the JWT, wrapped + // in a JWK try { rsaJsonWebKey = RsaJwkGenerator.generateJwk(2048); rsaJsonWebKey.setKeyId("k1"); testJwk = new HashMap<>(); testJwk.put("kty", rsaJsonWebKey.getKeyType()); - testJwk.put("e", BigEndianBigInteger.toBase64Url(rsaJsonWebKey.getRsaPublicKey().getPublicExponent())); + testJwk.put( + "e", + BigEndianBigInteger.toBase64Url(rsaJsonWebKey.getRsaPublicKey().getPublicExponent())); Review comment: Some of this spotless formatting is so awkward, maybe we could go with a slightly longer line length to make this less bad? Probably not important right now anyway, but thinking ahead to when we apply the plugin other places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
