risdenk commented on a change in pull request #637:
URL: https://github.com/apache/solr/pull/637#discussion_r811234114
##########
File path: solr/solrj/build.gradle
##########
@@ -62,6 +62,7 @@ dependencies {
testImplementation project(':solr:test-framework')
testImplementation project(':solr:core')
testImplementation project(':solr:solrj')
+ testRuntimeOnly project(':solr:modules:sql')
Review comment:
@dsmiley had a comment about this on the jira as well regarding moving
the solrj tests -> sql module. `JdbcTest` and one of the streamingexpressions
jdbc test are what is failing without the `testRuntimeOnly
project(':solr:modules:sql')`. I'm not sure it makes sense to move the `solrj`
jdbc tests to `solr:modules:sql` since they are really solrj tests. The solrj
tests are testing that solrj actually works w/ the SQL module. So I kinda like
how the dependencies are defined right now.
Regarding solrj-jdbc module - I would think so unless streaming expressions
is somehow still in solrj-core or whatever it will be called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
