HoustonPutman commented on a change in pull request #637:
URL: https://github.com/apache/solr/pull/637#discussion_r811236815
##########
File path: solr/solrj/build.gradle
##########
@@ -62,6 +62,7 @@ dependencies {
testImplementation project(':solr:test-framework')
testImplementation project(':solr:core')
testImplementation project(':solr:solrj')
+ testRuntimeOnly project(':solr:modules:sql')
Review comment:
yeah, definitely don't think they should go in the module, definitely
leave them where they are for now. I think this is good to go, and the
somewhat-recursive looking dependency (though it's test vs src, so not really
recursive) will eventually go away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
