dsmiley commented on a change in pull request #637:
URL: https://github.com/apache/solr/pull/637#discussion_r811259296
##########
File path: solr/solrj/build.gradle
##########
@@ -62,6 +62,7 @@ dependencies {
testImplementation project(':solr:test-framework')
testImplementation project(':solr:core')
testImplementation project(':solr:solrj')
+ testRuntimeOnly project(':solr:modules:sql')
Review comment:
I disagree but I'm not going to hold this up. If we're adding a
dependency between our modules that can be avoided simply by moving a test --
that's a "smell" to me, and the test should move. I think it's natural that a
module might have "solrj level tests" to exercise the backend functional by
using higher level APIs... that shouldn't mean (IMO) that SolrJ tests need to
depend on nearly everything. At least that's the direction this will go if we
follow your logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
