markrmiller commented on a change in pull request #585:
URL: https://github.com/apache/solr/pull/585#discussion_r827337036
##########
File path: solr/core/build.gradle
##########
@@ -90,6 +90,7 @@ dependencies {
implementation 'org.apache.httpcomponents:httpcore'
compileOnlyApi 'javax.servlet:javax.servlet-api'
+ compileOnlyApi 'org.eclipse.jetty.toolchain:jetty-servlet-api'
Review comment:
Not sure what you want to do here. If I remove that,
analyzeClassDependencies will fail.
Here is the details on that toolchain module, appears to be part of what is
needed to build Jetty: https://github.com/eclipse/jetty.toolchain
Here is a dependency insight call on that lib:
org.eclipse.jetty.toolchain:jetty-servlet-api:4.0.6
+--- project :
| \--- runtimeClasspath
+--- org.eclipse.jetty:jetty-rewrite:10.0.8
| +--- runtimeClasspath
| \--- project : (requested org.eclipse.jetty:jetty-rewrite:{strictly
10.0.8}) (*)
\--- org.eclipse.jetty:jetty-server:10.0.8
+--- runtimeClasspath
+--- project : (requested org.eclipse.jetty:jetty-server:{strictly
10.0.8}) (*)
+--- io.dropwizard.metrics:metrics-jetty9:4.1.5 (requested
org.eclipse.jetty:jetty-server:9.4.27.v20200227)
| +--- runtimeClasspath
| \--- project : (requested
io.dropwizard.metrics:metrics-jetty9:{strictly 4.1.5}) (*)
+--- org.eclipse.jetty:jetty-rewrite:10.0.8 (*)
+--- org.eclipse.jetty:jetty-security:10.0.8
| +--- runtimeClasspath
| +--- project : (requested
org.eclipse.jetty:jetty-security:{strictly 10.0.8}) (*)
| \--- org.eclipse.jetty:jetty-servlet:10.0.8
| +--- runtimeClasspath
| +--- project : (requested
org.eclipse.jetty:jetty-servlet:{strictly 10.0.8}) (*)
| \--- org.eclipse.jetty:jetty-webapp:10.0.8
| +--- runtimeClasspath
| +--- project : (requested
org.eclipse.jetty:jetty-webapp:{strictly 10.0.8}) (*)
| \--- org.eclipse.jetty:jetty-deploy:10.0.8
| +--- runtimeClasspath
| \--- project : (requested
org.eclipse.jetty:jetty-deploy:{strictly 10.0.8}) (*)
+--- org.eclipse.jetty:jetty-alpn-server:10.0.8
| +--- runtimeClasspath
| +--- project : (requested
org.eclipse.jetty:jetty-alpn-server:{strictly 10.0.8}) (*)
| \--- org.eclipse.jetty:jetty-alpn-java-server:10.0.8
| +--- runtimeClasspath
| \--- project : (requested
org.eclipse.jetty:jetty-alpn-java-server:{strictly 10.0.8}) (*)
\--- org.eclipse.jetty.http2:http2-server:10.0.8
+--- runtimeClasspath
\--- project : (requested org.eclipse.j
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
