markrmiller commented on a change in pull request #585:
URL: https://github.com/apache/solr/pull/585#discussion_r827341958
##########
File path: solr/core/src/java/org/apache/solr/request/json/RequestUtil.java
##########
@@ -68,8 +69,12 @@ public static void processParams(SolrRequestHandler handler,
SolrQueryRequest re
String[] jsonFromParams = map.remove(JSON); // params from the query
string should come after (and hence override) JSON content streams
for (ContentStream cs : req.getContentStreams()) {
+ // if BinaryResponseParser.BINARY_CONTENT_TYPE, let the following fail
below - we may have adjusted the content without updating the content type
+ // problem in this case happens in a few tests, one seems to happen
with kerberos and remote node query (HttpSolrCall's request proxy)
Review comment:
Good find, and that does jive with what was happening when I found the
fail I saw here pop up on the mailing list in the past.
So I think the diagnosis makes sense, and the change sounds reasonable high
level, but I am concerned that it requires that you can inspect the stream or
count on the content-size header to properly describe the stream. You cannot
generally do that though. The size is not required, usually not given in Solr,
and you can't reasonable inspect a stream in a webapp/servlet unless you buffer
it, which is also problematic. Given we are talking about a steram on a GET
request, maybe somehow you can get away with this, but it seems pretty fragile?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
