madrob commented on a change in pull request #585:
URL: https://github.com/apache/solr/pull/585#discussion_r827346145
##########
File path: solr/core/src/java/org/apache/solr/request/json/RequestUtil.java
##########
@@ -68,8 +69,12 @@ public static void processParams(SolrRequestHandler handler,
SolrQueryRequest re
String[] jsonFromParams = map.remove(JSON); // params from the query
string should come after (and hence override) JSON content streams
for (ContentStream cs : req.getContentStreams()) {
+ // if BinaryResponseParser.BINARY_CONTENT_TYPE, let the following fail
below - we may have adjusted the content without updating the content type
+ // problem in this case happens in a few tests, one seems to happen
with kerberos and remote node query (HttpSolrCall's request proxy)
Review comment:
RawRequestParser.parseParamsAndFillStreams will proactively save the
stream if there is a content length `>= 0` - that should probably be strictly
`> 0`. Because then in the else block, if it's not a GET we try to buffer the
first byte - if it exists, save the stream again and if not then we don't need
it. I think we need to fix RawRequestParser with this PR to accommodate the
change that Jetty made - it's likely a regression but I couldn't find an
existing bug report or an easy reproducer for them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
