epugh commented on code in PR #924:
URL: https://github.com/apache/solr/pull/924#discussion_r913697233
##########
solr/core/src/test/org/apache/solr/cloud/PeerSyncReplicationTest.java:
##########
@@ -289,15 +288,13 @@ private CloudJettyRunner
forceNodeFailureAndDoPeerSync(boolean disableFingerprin
indexDoc(id, docId, i1, 50, tlong, 50, t1, "document number " + docId++);
commit();
- bringUpDeadNodeAndEnsureNoReplication(replicaToShutDown,
disableFingerprint);
+ bringUpDeadNodeAndEnsureNoReplication(replicaToShutDown);
return replicaToShutDown;
}
- private void bringUpDeadNodeAndEnsureNoReplication(
- CloudJettyRunner nodeToBringUp, boolean disableFingerprint) throws
Exception {
- // disable fingerprint check if needed
- System.setProperty("solr.disableFingerprint",
String.valueOf(disableFingerprint));
Review Comment:
So, I think this NEVER got a value of true... The disableFingerprint was
never set to TRUE in the tests... In fact, I found another place where we
clear the property that we never set... You are probably right this shoiuld
be it's own issue... on the other hand I'm right in it now... sigh..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
