cpoerschke commented on code in PR #924:
URL: https://github.com/apache/solr/pull/924#discussion_r913914168
##########
solr/core/src/test/org/apache/solr/update/PeerSyncWithIndexFingerprintCachingTest.java:
##########
@@ -110,6 +110,6 @@ void assertSync(SolrClient client, int numVersions, boolean
expectedResult, Stri
"sync",
StrUtils.join(Arrays.asList(syncWith), ',')));
NamedList<?> rsp = client.request(qr);
- assertEquals(expectedResult, rsp.get("sync"));
+ assertEquals(true, rsp.get("sync"));
Review Comment:
```suggestion
assertTrue(rsp.get("sync"));
```
##########
solr/core/src/test/org/apache/solr/update/TestInPlaceUpdateWithRouteField.java:
##########
@@ -160,9 +160,9 @@ private void checkWrongCommandFailure(SolrInputDocument
sdoc)
}
}
- private Collection<SolrInputDocument> createDocs(int number) {
+ private Collection<SolrInputDocument> createDocs() {
List<SolrInputDocument> result = new ArrayList<>();
- for (int i = 0; i < number; i++) {
+ for (int i = 0; i < TestInPlaceUpdateWithRouteField.NUMBER_OF_DOCS; i++) {
Review Comment:
```suggestion
for (int i = 0; i < NUMBER_OF_DOCS; i++) {
```
##########
solr/core/src/test/org/apache/solr/update/PeerSyncWithLeaderAndIndexFingerprintCachingTest.java:
##########
@@ -41,6 +41,6 @@ void assertSync(SolrClient client, int numVersions, boolean
expectedResult, Stri
StrUtils.join(Arrays.asList(syncWith), ',')));
@SuppressWarnings({"rawtypes"})
NamedList rsp = client.request(qr);
- assertEquals(expectedResult, (Boolean) rsp.get("syncWithLeader"));
+ assertEquals(true, (Boolean) rsp.get("syncWithLeader"));
Review Comment:
```suggestion
assertTrue(rsp.get("syncWithLeader"));
```
##########
solr/core/src/test/org/apache/solr/request/SimpleFacetsTest.java:
##########
@@ -1253,9 +1253,8 @@ public void testDateRangeFieldFacets() {
private void helpTestDateFacets(final String fieldName, final
FacetRangeMethod rangeFacetMethod) {
Review Comment:
I'm gonna be awkward here and propose renaming of the parameter as an
alternative i.e. smaller diff and keeps style of the test intact with the
`p/b/f/c` etc. variable names style.
```suggestion
private void helpTestDateFacets(final String f, final FacetRangeMethod
rangeFacetMethod) {
```
(I'll push change directly to the PR branch if that's alright.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
