cpoerschke commented on code in PR #924:
URL: https://github.com/apache/solr/pull/924#discussion_r913939802
##########
solr/core/src/test/org/apache/solr/schema/TestCloudSchemaless.java:
##########
@@ -63,7 +63,8 @@ protected String getCloudSolrConfig() {
@Override
public SortedMap<ServletHolder, String> getExtraServlets() {
- final SortedMap<ServletHolder, String> extraServlets = new TreeMap<>();
Review Comment:
Hmm, it perhaps didn't matter because it used the method from the base
class? There's a little bit of `getExtraServlets` sprinkled across the code
base -- https://github.com/apache/solr/search?q=getExtraServlets -- let's
out-scope here and clean that up separately.
https://github.com/apache/solr/pull/924/commits/392f09ee184d61e92c8405d25ac0c25052b734d1
added to defer.
##########
solr/core/src/test/org/apache/solr/request/SimpleFacetsTest.java:
##########
@@ -1253,9 +1253,8 @@ public void testDateRangeFieldFacets() {
private void helpTestDateFacets(final String fieldName, final
FacetRangeMethod rangeFacetMethod) {
Review Comment:
https://github.com/apache/solr/pull/924/commits/edd62f508b69bbd8147e693dfc208f2f35ccf4e5
pushed to the branch.
##########
solr/core/src/test/org/apache/solr/cloud/PeerSyncReplicationTest.java:
##########
@@ -289,15 +288,13 @@ private CloudJettyRunner
forceNodeFailureAndDoPeerSync(boolean disableFingerprin
indexDoc(id, docId, i1, 50, tlong, 50, t1, "document number " + docId++);
commit();
- bringUpDeadNodeAndEnsureNoReplication(replicaToShutDown,
disableFingerprint);
+ bringUpDeadNodeAndEnsureNoReplication(replicaToShutDown);
return replicaToShutDown;
}
- private void bringUpDeadNodeAndEnsureNoReplication(
- CloudJettyRunner nodeToBringUp, boolean disableFingerprint) throws
Exception {
- // disable fingerprint check if needed
- System.setProperty("solr.disableFingerprint",
String.valueOf(disableFingerprint));
Review Comment:
https://github.com/apache/solr/pull/924/commits/c20b02e64f1a6b3fde9b018845cad22c683534e5
added to defer please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
